Fix Path.as_uri on Python 3.14 - #3460
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3460 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 128 128
Lines 19417 19419 +2
Branches 1317 1317
===============================================
+ Hits 19417 19419 +2
🚀 New features to boost your workflow:
|
A5rocks
left a comment
There was a problem hiding this comment.
Thanks, this is fine. For future contributions to Trio, please don't write PR text/comments with an LLM!
| if sys.version_info >= (3, 13): | ||
| full_match = _wrap_method(pathlib.Path.full_match) | ||
|
|
||
| # TODO: only allow this for Python <3.19. |
|
Hey @nyxst4ck, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂 If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:
If you want to read more, here's the relevant section in our contributing guide. Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you. If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out! |
Summary
trio.Path.as_uri()through the concrete wrappedpathlib.PathclassPurePath.as_uri()pathTests
uv run pytest src/trio/_tests/test_path.py -qgit diff --check